Skip to content

Download link should download documents, regardless of the Force Download setting. It doesn't. #19

Description

@mike-brearton-dtl

Describe the bug
The "Download" link should download the document, regardless of the "Open Link in New Browser Window" setting. It doesn't.

To Reproduce
Steps to reproduce the behavior:

  1. Add a document, ensuring Force Download is not ticked
  2. View the list of documents, and click on the "Download" link
  3. You will notice the forcedownload=true parameter of the hyperlink has not been added

Expected behavior
When the Force Download is not ticked, the Download link should still download the file; instead of opening it in the browser window.

DNN Information (please complete the following information):

  • DNN Version 9.9.1
  • Documents Module Version 7.01.00

Desktop (please complete the following information):

  • OS: Win 10
  • Browser: Edge or Chrome

Additional context
I know the code fix, and have emailed Mitchel Sellers for permission/instructions for how to get the fix implemented.

  • File = Document.ascx.vb
  • Line = 212
  • Old line:
    .NavigateUrl = DotNetNuke.Common.Globals.LinkClick(objDocument.Url, TabId, ModuleId, objDocument.TrackClicks, objDocument.ForceDownload)
  • New line:
    .NavigateUrl = DotNetNuke.Common.Globals.LinkClick(objDocument.Url, TabId, ModuleId, objDocument.TrackClicks, True)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions