Describe the bug
The "Download" link should download the document, regardless of the "Open Link in New Browser Window" setting. It doesn't.
To Reproduce
Steps to reproduce the behavior:
- Add a document, ensuring Force Download is not ticked
- View the list of documents, and click on the "Download" link
- You will notice the forcedownload=true parameter of the hyperlink has not been added
Expected behavior
When the Force Download is not ticked, the Download link should still download the file; instead of opening it in the browser window.
DNN Information (please complete the following information):
- DNN Version 9.9.1
- Documents Module Version 7.01.00
Desktop (please complete the following information):
- OS: Win 10
- Browser: Edge or Chrome
Additional context
I know the code fix, and have emailed Mitchel Sellers for permission/instructions for how to get the fix implemented.
- File = Document.ascx.vb
- Line = 212
- Old line:
.NavigateUrl = DotNetNuke.Common.Globals.LinkClick(objDocument.Url, TabId, ModuleId, objDocument.TrackClicks, objDocument.ForceDownload)
- New line:
.NavigateUrl = DotNetNuke.Common.Globals.LinkClick(objDocument.Url, TabId, ModuleId, objDocument.TrackClicks, True)
Describe the bug
The "Download" link should download the document, regardless of the "Open Link in New Browser Window" setting. It doesn't.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
When the Force Download is not ticked, the Download link should still download the file; instead of opening it in the browser window.
DNN Information (please complete the following information):
Desktop (please complete the following information):
Additional context
I know the code fix, and have emailed Mitchel Sellers for permission/instructions for how to get the fix implemented.
.NavigateUrl = DotNetNuke.Common.Globals.LinkClick(objDocument.Url, TabId, ModuleId, objDocument.TrackClicks, objDocument.ForceDownload)
.NavigateUrl = DotNetNuke.Common.Globals.LinkClick(objDocument.Url, TabId, ModuleId, objDocument.TrackClicks, True)