Skip to content

Abandon globussdk<4#663

Merged
Cadair merged 4 commits intoDKISTDC:mainfrom
SolarDrew:globussdk
Jan 14, 2026
Merged

Abandon globussdk<4#663
Cadair merged 4 commits intoDKISTDC:mainfrom
SolarDrew:globussdk

Conversation

@SolarDrew
Copy link
Contributor

@SolarDrew SolarDrew commented Jan 9, 2026

Continuing to support globussdk 3.x is probably going to be more trouble than it's worth.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026 •
edited
Loading

Merging this PR will improve performance by 12.21%

⚡ 1 improved benchmark
✅ 13 untouched benchmarks
⏩ 4 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation test_pixel_to_world 172.5 ms 153.8 ms +12.21%

Comparing SolarDrew:globussdk (bef89bd) with main (79a1d49)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (2ea167a) during the generation of this report, so 79a1d49 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Cadair
Copy link
Member

Cadair commented Jan 13, 2026

We should hopefully be able to remove the crytography pin here:

dkist/tox.ini

Lines 66 to 67 in f7843d8

# We need to pin down the cryptography transitive dependency because of globus
oldestdeps: pip install -r requirements-min.txt cryptography<42

??

@Cadair Cadair merged commit b112d34 into DKISTDC:main Jan 14, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cadair Cadair Cadair approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SolarDrew @Cadair