Fix sorting of Fried Parameter in UnifiedResponse#651
Merged
Cadair merged 5 commits intoDKISTDC:mainfrom Dec 9, 2025
Merged
Conversation
Member
|
yeah we should definitely factor this out into a helper function. We can then build on it in #557 |
Cadair
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #612
Changes processing of Fido results to create a new column for r0, and populates it with the data that isn't
Nones, instead of directly changing theNones toNaNs. This is because the problem with sorting seems to have been that the column haddtype='object', so this makes a new one withdtype='float64'instead.This should probably also add some kind of tests to make sure that the sorting actually works. May also need to apply the same treatment to other columns in which
Nones are replaced.