Change FileManager.basepath behaviour to work on Windows#647
Merged
Cadair merged 22 commits intoDKISTDC:mainfrom Nov 18, 2025
Merged
Change FileManager.basepath behaviour to work on Windows#647Cadair merged 22 commits intoDKISTDC:mainfrom
Cadair merged 22 commits intoDKISTDC:mainfrom
Conversation
SolarDrew
changed the title
Contributor
Author
|
Well this is mostly passing now but I have no idea why the coverage has suddenly disappeared. |
Cadair
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #615
Changes the basepath passed to Globus to be relative to the user's home directory unless it has a different root (eg/data/will be unchanged). This should have no user-facing effect on Linux. On Windows it will have the advantage of making downloads actually work, but the downside is that Globus will download files to wherever its default configuration for~/is. It looks like there's no way for the user tools to know where this is or change it, so the user will have to find that out themselves by looking in the globus config, and change it there if they don't like it.Docs explaining the above will be added here.Most of the above is not true any more. Now this PR actually just edits the destination path given to globus so that it uses
/C/on Windows instead ofC:/, which globus doesn't know how to deal with. This may require Windows users to adjust their allowed paths in globus, and docs will be added to that effect.