Merged
Conversation
af97e15 to
b634a46
Compare
b634a46 to
6c6f7e7
Compare
Cadair
reviewed
Oct 1, 2025
Unconvinced of the utility of some of them, but here we are
Cadair
requested changes
Oct 9, 2025
Cadair
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deals with all the fiddly nonsense of changing a dozen things every time we have to bump a schema version.
Handles updating an existing schema:
dkist/io/asdf/resources/manifests/dkist-1.6.0.yamlis a copy ofdkist-1.5.0.yamlwith all the appropriate version numbers bumped; likewisedkist/io/asdf/resources/schemas/dataset-1.3.0.yamlincrementsdataset-1.2.0.yaml.Also handles creating a new schema:
In this case any necessary new files are created as templates.
TODO:
Automate committing the changes, which will presumably run the pre-commit stuff and fix import orderings, linting etc.Decided against this.