Update transform schemas to support transform-1.4.0 schema#568
Merged
Cadair merged 5 commits intoDKISTDC:mainfrom Jul 1, 2025
Merged
Update transform schemas to support transform-1.4.0 schema#568Cadair merged 5 commits intoDKISTDC:mainfrom
Cadair merged 5 commits intoDKISTDC:mainfrom
Conversation
CodSpeed Performance ReportMerging #568 will not alter performanceComparing Summary
|
Contributor
Author
|
The py313 failure was due to this PR being updated too soon after the asdf-transform-schemas release. I suspect re-triggering that run will allow it to succeed (but I don't seem to have that button). |
Contributor
Author
|
@Cadair I'm starting the process of releasing asdf-astropy with the version check for the manifest version introduced in this PR. If there are plans to publish a different |
Member
|
We are likely to do a new manifest or two soon, but you are welcome to 1.5 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new version of asdf-transform-schemas will soon be released with a new transform-1.4.0 schema. See asdf-format/asdf-transform-schemas#120 for more details on the motivation for the new schema (tldr; this decouples the transform schemas from the core schemas in the standard to allow easier fixes for things like the ndarray mask bug: asdf-format/asdf#1909).
This PR updates the dkist wcs schemas to use the new transform-1.4.0 schema.
A related asdf-astropy PR (astropy/asdf-astropy#279) includes checks to verify the updates don't break the current dkist release due to a sort of self-referencing issue with the now old transform-1.3.0 schema. That PR makes the assumption that the dkist changes in this PR will end up in manifest 1.5.0.
This PR is part of an effort to untangle some dependencies in transform schemas. See asdf-format/asdf-wcs-schemas#68 for probably too much context.