Conversation
SolarDrew
left a comment
SolarDrew
left a comment
There was a problem hiding this comment.
Just a couple of minor comments
Co-authored-by: Drew Leonard <[email protected]>
eigenbrot
left a comment
eigenbrot
left a comment
There was a problem hiding this comment.
I know this was already merged, but here are my comments all the same. Sorry for the late reply.
|
|
||
| ```{code-cell} ipython3 | ||
| ds = dkist.load_dataset(asdf_file) | ||
| ds = dkist.load_dataset(VBI_AJQWW / "VBI_L1_20231016T184519_AJQWW.asdf") |
There was a problem hiding this comment.
For me this works without needing to specify the metadata filename. I.e., ds = dkist.load_dataset(VBI_AJQWW) works. Do we care about that difference here?
There was a problem hiding this comment.
This is specifically to temporarily work around the issue with differently named asdfs.
| Downloading the Sample Data with Globus | ||
| ======================================= | ||
|
|
||
| The Python tools provide a few different partial datasets as sample data, these are used in documentation and examples. |
There was a problem hiding this comment.
How about "...sample data, which are used..."?
| ======================================= | ||
|
|
||
| The Python tools provide a few different partial datasets as sample data, these are used in documentation and examples. | ||
| This how to guide will show you how to download the complete data for these datasets, or let you change the dataset for a different one. |
There was a problem hiding this comment.
Maybe capitalize "How To Guide"?
Also the last clause reads a little weird. Maybe "..., or any dataset you want." or something similar?
| Searching for and downloading the ASDF file | ||
| ------------------------------------------- | ||
|
|
||
| Using the `BKPLX <https://dkist.data.nso.edu/datasetview/BKPLX>`__ dataset from the VISP we download the ASDF file and create a `dkist.Dataset` object. |
There was a problem hiding this comment.
Looking to the future that this PR is creating we should probably replace references to an "ASDF file" with something like "metadata file".
| import dkist.net | ||
|
|
||
| results = Fido.search(a.dkist.Dataset("BKPLX")) | ||
| asdf_file = Fido.fetch(results) |
There was a problem hiding this comment.
asdf_file -> metadata_file?
| Downloading the FITS files with Globus | ||
| -------------------------------------- | ||
|
|
||
| Having loaded the ASDF file into a `dkist.Dataset` as this is a VISP dataset with polarimetry, we can download the Stokes I profile by indexing the first element of the first dimension: |
There was a problem hiding this comment.
"This ViSP dataset has a polarimetric (Stokes) axis and so we can download only Stokes-I data by indexing to the first element of the first dimension:"
| ``` | ||
|
|
||
| We can now make a composite plot of all the tiles. | ||
| We can now make a composite plot of all the tiles, at the first timestep. |
3 participants
Also stub out howto guides section