Add support to TiledDataset for missing, irregular or overlapping tiles#487
Merged
Cadair merged 61 commits intoDKISTDC:mainfrom Mar 20, 2025
Merged
Add support to TiledDataset for missing, irregular or overlapping tiles#487Cadair merged 61 commits intoDKISTDC:mainfrom
Cadair merged 61 commits intoDKISTDC:mainfrom
Conversation
CodSpeed Performance ReportMerging #487 will not alter performanceComparing Summary
Benchmarks breakdown
|
Cadair
reviewed
Jan 14, 2025
Cadair
reviewed
Jan 20, 2025
Cadair
reviewed
Jan 20, 2025
Cadair
reviewed
Jan 20, 2025
Contributor
Author
|
There are a few places where this can still be improved - if we're happy to make issues for those and punt them then this is good to go pending review. Otherwise I'll come back to it on Monday. |
Cadair
reviewed
Jan 21, 2025
Member
Cadair
left a comment
Cadair
left a comment
There was a problem hiding this comment.
👍 This looks good.
I think we should postpone merging this until we have made the corresponding changes to dkist-inventory just to make sure we haven't missed anything.
Co-authored-by: Stuart Mumford <[email protected]>
SolarDrew
force-pushed
the
tiledds-improvements
branch
from
c8ef224 to
a90a49f
Compare
Cadair
reviewed
Feb 19, 2025
Contributor
Author
Does this not test the latter? |
Contributor
Author
Apparently not because those lines aren't getting hit. |
…o tiledds-improvements
…o tiledds-improvements
…o tiledds-improvements
Cadair
reviewed
Mar 20, 2025
Cadair
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the array of datasets underlying TiledDataset into a masked array, defaulting to False everywhere (all tiles are valid).