Skip to content

feat: 添加NBA频道#2553

Merged
DIYgod merged 8 commits intoDIYgod:masterfrom
alizeegod:feature/nba
Jul 4, 2019
Merged

feat: 添加NBA频道#2553
DIYgod merged 8 commits intoDIYgod:masterfrom
alizeegod:feature/nba

Conversation

@alizeegod
Copy link
Copy Markdown
Contributor

添加NBA频道

Comment thread lib/routes/nba/app_news.js Outdated
Object.keys(xmls).map(async (xml) => {
const data = xmls[xml];
const link = data.shareUrl;
const cache = await ctx.cache.get(link);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有全文请求,不需要使用缓存和Promise.all

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment thread lib/routes/nba/app_news.js Outdated

return item;
});
console.log(out);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余 console.log

@DIYgod DIYgod merged commit 614869e into DIYgod:master Jul 4, 2019
@DIYgod
Copy link
Copy Markdown
Owner

DIYgod commented Jul 4, 2019

Merged, thanks!

iplusx added a commit to iplusx/RSSHub that referenced this pull request Jul 6, 2019
* master: (38 commits)
  fix: 兼容长微博 (DIYgod#2566)
  long text compatible
  Revert "long text compatible"
  long text compatible
  fix: zaker some url 302 (DIYgod#2559)
  feat: 微博全文和准确的微博发布时间 (DIYgod#2546)
  add referer
  feat: add 中南大学招聘信息 (DIYgod#2556)
  feat: 添加NBA频道 (DIYgod#2553)
  chore(deps): update dependency rss-parser to v3.7.2 (DIYgod#2539)
  chore(deps): update dependency form-data to v2.5.0 (DIYgod#2554)
  chore(deps): update dependency luxon to v1.16.1 (DIYgod#2552)
  feat: add zaker channel (DIYgod#2550)
  fix: change uread docs (DIYgod#2549)
  feat: 增加财新网首页新闻、中国政府网滚动新闻、中国政府网新闻要闻 (DIYgod#2533)
  fix: apkpure cn pubDate (DIYgod#2547)
  feat: add aptonic Dropzone action (DIYgod#2545)
  fix code style
  fix: remove unused var
  Revert "Add Instagram account's profile image URL."
  ...
iplusx added a commit to iplusx/RSSHub that referenced this pull request Jul 6, 2019
* wangjunyu: (38 commits)
  fix: 兼容长微博 (DIYgod#2566)
  long text compatible
  Revert "long text compatible"
  long text compatible
  fix: zaker some url 302 (DIYgod#2559)
  feat: 微博全文和准确的微博发布时间 (DIYgod#2546)
  add referer
  feat: add 中南大学招聘信息 (DIYgod#2556)
  feat: 添加NBA频道 (DIYgod#2553)
  chore(deps): update dependency rss-parser to v3.7.2 (DIYgod#2539)
  chore(deps): update dependency form-data to v2.5.0 (DIYgod#2554)
  chore(deps): update dependency luxon to v1.16.1 (DIYgod#2552)
  feat: add zaker channel (DIYgod#2550)
  fix: change uread docs (DIYgod#2549)
  feat: 增加财新网首页新闻、中国政府网滚动新闻、中国政府网新闻要闻 (DIYgod#2533)
  fix: apkpure cn pubDate (DIYgod#2547)
  feat: add aptonic Dropzone action (DIYgod#2545)
  fix code style
  fix: remove unused var
  Revert "Add Instagram account's profile image URL."
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants