Skip to content

fix: 小黑盒热门折扣#2237

Merged
DIYgod merged 1 commit intomasterfrom
unknown repository
May 27, 2019
Merged

fix: 小黑盒热门折扣#2237
DIYgod merged 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 26, 2019

以后在文档写明先 npm install && npm run format 好嘛 💦

Ref: #2216 #2235

以后在文档写明先 `npm install && npm run format` 好嘛 💦
@SettingDust
Copy link
Copy Markdown
Contributor

SettingDust commented May 26, 2019

执行 npm run format 自动标准化代码格式,提交代码, 然后提交 pull request

请仔细阅读文档,同为阿卡林,太丢脸了!

@ghost
Copy link
Copy Markdown
Author

ghost commented May 27, 2019

把最重要的部分放在最后一行,然后说不仔细阅读文档 💦
这意味着只是改一行 Travis CI 也不一定给过,必须要整个项目 clone 下来,npm install && npm run format 才能发 PR,应该在文档最开头就要说明的……

@SettingDust
Copy link
Copy Markdown
Contributor

Push上去都不检查自己过没过CI,这种错误是正常的

@DIYgod DIYgod merged commit 0bb5acf into DIYgod:master May 27, 2019
@DIYgod
Copy link
Copy Markdown
Owner

DIYgod commented May 27, 2019

Merged, thanks!

iplusx added a commit to iplusx/RSSHub that referenced this pull request May 31, 2019
* master: (47 commits)
  feat: Bilibii 关注专栏 (DIYgod#2260)
  feat: WIRED杂志根据标签订阅 (DIYgod#2262)
  docs: fix typo
  fix: douban movie
  feat: remove weibo/user2, close DIYgod#2169
  fix: notch time (DIYgod#2259)
  fix: 鼠绘无法获取最新漫画bug (DIYgod#2257)
  feat: 增加 Hacker News 内容 (DIYgod#2253)
  feat: 添加了移动支付网分类 (DIYgod#2247)
  docs: 好奇怪文档示例错误 (DIYgod#2255)
  feat: 增加好奇怪 - 好奇心日报荣誉出品 (DIYgod#2252)
  feat: 添加新浪专栏-创事记 (DIYgod#2251)
  feat:添加cnBeta最新文章 (DIYgod#2249)
  docs: format
  docs: update qa
  fix: 小黑盒热门折扣 (DIYgod#2237)
  docs: update aqicn.org 文档说明 (DIYgod#2240)
  fix: fix saraba1st docs (DIYgod#2238)
  feat: 增加猫眼电影 (DIYgod#2234)
  fix: 修复 语雀知识库link 404报错 (DIYgod#2230)
  ...

# Conflicts:
#	lib/routes/twitter/user.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants