Skip to content

Hotfix: nytimes route#1900

Merged
DIYgod merged 1 commit intoDIYgod:masterfrom
xyqfer:hotfix-nytimes-route
Apr 10, 2019
Merged

Hotfix: nytimes route#1900
DIYgod merged 1 commit intoDIYgod:masterfrom
xyqfer:hotfix-nytimes-route

Conversation

@xyqfer
Copy link
Copy Markdown
Contributor

@xyqfer xyqfer commented Apr 9, 2019

由于先前的路由的注册顺序是/nytimes/:lang?/nytimes/morning_post,且lang参数为可选。当访问/nytimes/morning_post时实际上是走到了第一个路由也就是/nytimes/:lang?里(这种情况下第二个路由其实并没有起作用),导致输出内容不符合预期

因此调换两个路由的注册顺序可以解决这个问题

Closes #1886

@HenryQW
Copy link
Copy Markdown
Collaborator

HenryQW commented Apr 9, 2019

这么偷懒的吗凉凉

@DIYgod DIYgod merged commit 6418a76 into DIYgod:master Apr 10, 2019
@DIYgod
Copy link
Copy Markdown
Owner

DIYgod commented Apr 10, 2019

Merged, thanks!

@xyqfer xyqfer deleted the hotfix-nytimes-route branch April 11, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants