Merged
Conversation
# Conflicts: # docs/README.md # lib/router.js # yarn.lock
DIYgod
requested changes
Mar 8, 2019
docs/joinus/README.md
Outdated
| | lib/router.js 中的完整代码 | `router.get('/github/issue/:user/:repo', require('./routes/github/issue'));` | | ||
|
|
||
| 3. [embassy](https://github.com/DIYgod/RSSHub/blob/master/lib/routes/embassy/index.js) | ||
| 3. [embassy](https://github.com/DIYgod/RSSHub/blob/master/lib/routes/embassy/common-config.js) |
docs/en/joinus/README.md
Outdated
| | the complete code in lib/router.js | `router.get('/github/issue/:user/:repo', require('./routes/github/issue'));` | | ||
|
|
||
| 3. [embassy](https://github.com/DIYgod/RSSHub/blob/master/lib/routes/embassy/index.js) | ||
| 3. [embassy](https://github.com/DIYgod/RSSHub/blob/master/lib/routes/embassy/common-config.js) |
Procfile
Outdated
| @@ -1 +1 @@ | |||
| web: node lib/index.js | |||
| web: node lib/common-config.js | |||
docs/README.md
Outdated
|
|
||
| ### 裏垢女子まとめ | ||
|
|
||
| <route name="主页" author="SettingDust" example="/uraaka-joshi" path="/common/uraaka-joshi"/> |
| }; | ||
| } | ||
|
|
||
| module.exports = buildData; |
DIYgod
approved these changes
Mar 11, 2019
Owner
|
Merged, thanks! |
DerekTso
reviewed
Mar 14, 2019
| item: '.content-main .stream .stream-item', | ||
| title: `$('.post-name').text() + '@${params.id} - 裏垢女子まとめ'`, | ||
| link: `https://www.uraaka-joshi.com/users/${params.id}`, | ||
| description: `$('.post .context').html()`, |
Contributor
There was a problem hiding this comment.
@SettingDust
hi, it seems that we should handle the video item manually, not just parsing the html. The video tag misses the attribute "controls" and it won't show up at the rss reader ( e.g. feedly).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use js config too build rss
close #349 close #1035