Skip to content

Fix redundant doc build #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
d-chambers wants to merge 10 commits into from
Closed

Fix redundant doc build #545

d-chambers wants to merge 10 commits into from

Conversation

@d-chambers
Copy link
Contributor

@d-chambers d-chambers commented Sep 20, 2025

Description

Apparently, the docs were getting built twice in the publish master docs action. Once for build docs, then again when they are published to netlify. This PR just removes the first doc_build to improve speed and reduce redundancy.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 20, 2025

Warning

Rate limit exceeded

@d-chambers has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b766f2e and 6e6747f.

📒 Files selected for processing (7)
  • .github/workflows/build_deploy_master_docs.yaml (0 hunks)
  • dascore/core/patch.py (1 hunks)
  • dascore/proc/__init__.py (1 hunks)
  • dascore/proc/hampel.py (1 hunks)
  • docs/recipes/despiking.qmd (1 hunks)
  • scripts/_templates/_quarto.yml (1 hunks)
  • tests/test_proc/test_hampel.py (1 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch redundant_doc_build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.92%. Comparing base (25b4b75) to head (6e6747f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #545   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         124      125    +1     
  Lines       10336    10435   +99     
=======================================
+ Hits        10328    10427   +99     
  Misses          8        8
Flag Coverage Δ
unittests 99.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-chambers d-chambers closed this Sep 20, 2025
@d-chambers
Copy link
Contributor Author

d-chambers commented Sep 20, 2025

Wrong base branch ...

@d-chambers d-chambers deleted the redundant_doc_build branch September 20, 2025 15:38
@d-chambers d-chambers mentioned this pull request Sep 20, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d-chambers