dascore/proc/correlate.py (1)

191-195: Fix deprecation message grammar and point warning at caller.

The message is missing the verb “select,” and the warning should use stacklevel so it points to user code (this function is wrapped by patch_function).

-        msg = (
-            "Correlate lag is deprecated and does nothing. "
-            "Simply use on the output patch."
-        )
-        warnings.warn(msg, DeprecationWarning)
+        msg = (
+            "Parameter 'lag' is deprecated and ignored. "
+            "Use Patch.select on the output patch (e.g., select(lag_time=(...)))."
+        )
+        warnings.warn(msg, category=DeprecationWarning, stacklevel=3)

tests/test_utils/test_deprecated.py (1)

7-7: Redundant import alias.

Drop the no-op “as deprecate”.

-from dascore.utils.deprecate import deprecate as deprecate
+from dascore.utils.deprecate import deprecate

dascore/transform/fft.py (2)

21-26: Make deprecation decorator outermost so IDE/type-checkers see it.

Placing @deprecate outermost ensures the exported symbol carries the typing deprecation and doc augmentation.

-@patch_function()
-@deprecate(
+@deprecate(
     info="The Patch transform rfft is deprecated. Use dft instead.",
     removed_in="0.2.0",
 )
+@patch_function()
 def rfft(patch: PatchType, dim="time") -> PatchType:

---

30-32: Avoid duplicated deprecation text in the docstring.

The decorator already appends a deprecated section. Trim the manual “DEPRECATED FUNCTION” sentence to keep docs concise.

-    DEPRECATED FUNCTION: Use [dft](`dascore.transform.fourier.dft`) instead.
-    This function is not scaled as detailed in the dascore documentation.
+    See [dft](`dascore.transform.fourier.dft`) instead.
+    Note: this variant is not scaled as detailed in the documentation.

dascore/utils/patch.py (1)

328-336: Consider adding since= for clearer lifecycle and unify with decorator stacklevel.

Adding since="x.y.z" improves user messaging. Also, with the current deprecate() default stacklevel (see utils.deprecate), ensure warnings point to the user call site for non-patch functions like this one.

 @deprecate(
     info=(
         "merge_patches is deprecated. Use spool.chunk instead. "
         "For example, to merge a list of patches you can use: "
         "dascore.spool(patch_list).chunk(time=None) to merge on the time "
         "dimension."
     ),
+    since="0.1.0",
     removed_in="0.2.0",
 )

dascore/utils/deprecate.py (2)

34-36: Docstring nit: sentence case.

Capitalize “It” at the start of the sentence.

-        Short message shown in warnings and editor hints. it is useful to specify
+        Short message shown in warnings and editor hints. It is useful to specify

---

20-23: Stabilize warning text and make stacklevel configurable.

Using the function object in the message produces noisy, non-deterministic text. Prefer module-qualified name. Also, default stacklevel=2 works for plain functions; when combined with patch_function, making @deprecate outermost (see fft.py comment) preserves correct attribution without hard-coding 3.

 def deprecate(
     info: str = "",
     *,
     since: str | None = None,
     removed_in: str | None = None,
     category: type[Warning] = DeprecationWarning,
+    stacklevel: int = 2,
 ) -> Callable[[F], F]:
@@
-        def wrapper(*args: Any, **kwargs: Any):
-            msg = f"Function or method {func} is deprecated: \n" + message
-            warnings.warn(msg, category=category, stacklevel=3)
+        def wrapper(*args: Any, **kwargs: Any):
+            qual = f"{func.__module__}.{getattr(func, '__qualname__', func.__name__)}"
+            msg = f"{qual} is deprecated. {message}"
+            warnings.warn(msg, category=category, stacklevel=stacklevel)
             return func(*args, **kwargs)

Also applies to: 63-66

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

dascore/utils/deprecate.py (2)

49-51: Typo in docstring (“emmit” → “emit”)

-    def _build_msg(func):
-        """Build the message to emmit."""
+    def _build_msg(func):
+        """Build the message to emit."""

---

9-9: Preserve callable signatures with ParamSpec/TypeVar to avoid type: ignore

This removes the return-value ignore and gives precise typing for callers.

-from collections.abc import Callable
-from typing import Any, TypeVar
+from collections.abc import Callable
+from typing import Any, ParamSpec, TypeVar, cast
@@
-F = TypeVar("F", bound=Callable[..., Any])
+P = ParamSpec("P")
+R = TypeVar("R")
@@
-def deprecate(
+def deprecate(
     info: str = "",
     *,
     since: str | None = None,
     removed_in: str | None = None,
-) -> Callable[[F], F]:
+) -> Callable[[Callable[P, R]], Callable[P, R]]:
@@
-    def _decorate(func: F) -> F:
+    def _decorate(func: Callable[P, R]) -> Callable[P, R]:
@@
-        def wrapper(*args: Any, **kwargs: Any):
+        def wrapper(*args: P.args, **kwargs: P.kwargs) -> R:
             warnings.warn(
                 _build_msg(func),
                 category=DeprecationWarning,
                 stacklevel=2,
             )
             return func(*args, **kwargs)
@@
-        return dep(msg)(wrapper)  # type: ignore[return-value]
+        return cast(Callable[P, R], dep(msg)(wrapper))

Also applies to: 13-13, 16-21, 59-63, 75-77

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.