neubrex decimation check #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 115 115
Lines 9372 9374 +2
=======================================
+ Hits 9358 9360 +2
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I also updated the mamba setup to actually use the correct version of python (it appears the latest version was being used before). |
d-chambers
added a commit
that referenced
this pull request
Dec 21, 2024
* fix_463 * neubrex decimation check (#465) - also fixes CI mamba setup. * segyio dependency issue note made next to install instructions * clarify fetch in tutorials (#468) * fix_463 --------- Co-authored-by: eileenrmartin <[email protected]> Co-authored-by: Ahmad Tourei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the time/distance decimation check for reading neubrex DAS files. Previously, we simply raise an exception if the
DistanceDecimationFilteror theTimeDecimationFilterattributes are non-zero. This is because I was not sure if this is a binary flag indicating a low-pass anti-aliasing filter was applied (to either the time or space dimension) or if it is an integer value indicating the time/distance coordinate was decimated. For example, aDistanceDecimationFilter=2 could mean every other channel was discarded.It appears that some files (eg the forge neubrex das files) have a value of 1, so it is probably a binary flag. In this case, I don't think there is anything else for DASCore to do except add this info to the attrs.
This PR just allows
DistanceDecimationFilterandTimeDecimationFilterto be either 1 or 0 and addsdistance_decimation_filterandtime_decimation_filterto the patch attrs.@arturguzik, if you can confirm my intrepretation of the
TimeDecimationFilterandDistanceDecimationFilterparameters that would be useful. Thanks!Checklist
I have (if applicable):