Skip to content

Conversation

@ahmadtourei
Copy link
Collaborator

Description

This PR adds a method named patch_name() that returns the name of a patch in a directory spool.
It is related to discussion #460.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (ad2ecb5) to head (89b94e8).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files         115      115           
  Lines        9372     9387   +15     
=======================================
+ Hits         9358     9373   +15     
  Misses         14       14           
Flag Coverage Δ
unittests 99.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahmadtourei
Copy link
Collaborator Author

I wonder how I can get patch's name from memory spools so we can have another patch_name() method for memory spools. Please let me know your thoughts @d-chambers.

@ahmadtourei ahmadtourei added the ready_for_review PR is ready for review label Nov 27, 2024
@d-chambers
Copy link
Contributor

Ok, let's look at this a bit more next week. This week is rather busy with the holiday and the tutorial Monday.

@d-chambers d-chambers mentioned this pull request Dec 21, 2024
5 tasks
@d-chambers
Copy link
Contributor

superseded by #471.

@d-chambers d-chambers closed this Dec 24, 2024
@ahmadtourei ahmadtourei deleted the patch_name branch January 9, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready_for_review PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants