fix PatchType and SpoolType type var #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
=======================================
Coverage 99.85% 99.85%
=======================================
Files 115 115
Lines 9372 9372
=======================================
Hits 9358 9358
Misses 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
PatchTypeandSpoolTypetypevars in the constants module.These are
typevarswhich bind to a string (eg "dc.Patch") so other functions can use them and yet avoid circular imports.However, in #456 I had changed the bound string to "dc.Patch" to better support the idiomatic import of dascore as dc when using
patch_function's new validate_call feature. However, this broke a lot of the doc-build stuff which expected 'dascore.Patch'. This PR modifies the doc build's type indexing to allow for dc.{whatever} or dascore.{whatever}.Checklist
I have (if applicable):