Skip to content

get_coords to accept quantity #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d-chambers merged 3 commits into from
Nov 2, 2024
Merged

get_coords to accept quantity #453

d-chambers merged 3 commits into from
Nov 2, 2024

Conversation

@d-chambers
Copy link
Contributor

@d-chambers d-chambers commented Nov 1, 2024

Description

This PR does 2 things.

  • Adds some examples to the docstrings of Patch.get_array and Patch.get_coord
  • Allows quantities to be passed to get_coord with the values argument.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (f2bbd4c) to head (47ed705).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #453   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         114      114           
  Lines        9211     9217    +6     
=======================================
+ Hits         9197     9203    +6     
  Misses         14       14
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers d-chambers merged commit 68de7b5 into master Nov 2, 2024
@d-chambers d-chambers deleted the get_coords_data_units branch November 2, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d-chambers