Skip to content

pint numpy compat #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
d-chambers merged 1 commit into from
Sep 26, 2024
Merged

pint numpy compat #439

d-chambers merged 1 commit into from
Sep 26, 2024

Conversation

@d-chambers
Copy link
Contributor

@d-chambers d-chambers commented Sep 25, 2024

Description

This PR adds some compatibility code between numpy < 2 and numpy > 2 plus newer/older versions of pint.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes.
  • documented the new feature with docstrings or appropriate doc page.
  • included a test. See testing guidelines.
  • your name has been added to the contributors page (docs/contributors.md).
  • added the "ready_for_review" tag once the PR is ready to be reviewed.

@codecov
Copy link

codecov bot commented Sep 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (3858a11) to head (68aea38).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #439   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         114      114           
  Lines        9170     9172    +2     
=======================================
+ Hits         9156     9158    +2     
  Misses         14       14
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-chambers
Copy link
Contributor Author

d-chambers commented Sep 26, 2024

Mind taking a quick look at this @ahmadtourei?

@ahmadtourei
Copy link
Collaborator

ahmadtourei commented Sep 26, 2024

Mind taking a quick look at this @ahmadtourei?

Looks good!

@d-chambers d-chambers merged commit c7e3178 into master Sep 26, 2024
@d-chambers d-chambers deleted the pint_compat branch September 26, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmadtourei ahmadtourei ahmadtourei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@d-chambers @ahmadtourei