Thanks for opening a new PR @ahmadtourei.

Ok, so I didn't understand why raising a custom AttributeError when a spool.viz is accessed is not sufficient here?

eg

@property
def viz(self):
    raise AttributeError("spool has no viz namespace, perhaps you meant Patch.viz?")

Maybe you are envisioning adding spool visualization methods? In that case we might need to support the spool.viz namespace and just raise when .waterfall is accessed to address the mistake in the dascore diagram?

Thanks for opening a new PR @ahmadtourei.

Ok, so I didn't understand why raising a custom AttributeError when a spool.viz is accessed is not sufficient here?

eg

@property
def viz(self):
    raise AttributeError("spool has no viz namespace, perhaps you meant Patch.viz?")

Maybe you are envisioning adding spool visualization methods? In that case we might need to support the spool.viz namespace and just raise when .waterfall is accessed to address the mistake in the dascore diagram?

Agreed. The problem was the test I implemented. Please have a look at the new test and let me know if it looks good.

The test failures are a problem with the macos scipy build and nothing related to your changes. I will try to take a look tomorrow

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (cfce558) to head (5b9c56e).
Report is 2 commits behind head on master.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   99.28%   99.84%   +0.56%     
==========================================
  Files         112      112              
  Lines        9028     9032       +4     
==========================================
+ Hits         8963     9018      +55     
+ Misses         65       14      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The test failures are a problem with the macos scipy build and nothing related to your changes. I will try to take a look tomorrow

Thanks for the discussion on debugging test failures today! All tests pass.