-
Notifications
You must be signed in to change notification settings - Fork 28
Description
I just installed dascore using pip under conda env with python 3.11 (mac os sonoma)
The package requires an old version of numpy (1.26.4) that I had to remove to reinstall version 2.1.1
I ended up with errors in several function testing for np.NAN instead of np.nan:
line: pulse_width_ns: float = np.NAN
when NAN is replaced by nan, code runs fine
Sounds like recent versions of numpy do not accept any longer NAN instead of nan
files concerned:
dascore-master/tests/test_proc/test_filter.py: _ = random_patch.pass_filter(time=[None, np.NAN])
dascore-master/dascore/io/xml_binary/core.py: pulse_width_ns: float = np.NAN
dascore-master/dascore/io/dashdf5/core.py: pulse_width: float = np.NAN
dascore-master/dascore/io/prodml/core.py: pulse_width: float = np.NAN