fix_534

d-chambers · d-chambers · commit bf552065e654 · 2025-10-04T14:39:57.000+01:00
diff --git a/dascore/utils/plotting.py b/dascore/utils/plotting.py
@@ -65,7 +65,15 @@ def _convert_timedeltas(coords, lims):
     lims = {x: [] for x in dims_r}
     for dim in dims_r:
         array = coords[dim]
-        lims[dim] += [array.min(), array.max()]
+        # Use nanmin/nanmax to handle NaN/NaT values in coordinates
+        with suppress_warnings(RuntimeWarning):
+            array_min = np.nanmin(array)
+            array_max = np.nanmax(array)
+        # If all values are NaN/NaT, fall back to index-based extents
+        if np.isnan(array_min) or np.isnan(array_max):
+            array_min = 0
+            array_max = len(array) - 1
+        lims[dim] += [array_min, array_max]
     # find datetime coords and convert to numpy mtimes
     _convert_datetimes(coords, lims)
     _convert_timedeltas(coords, lims)
diff --git a/tests/test_viz/test_waterfall.py b/tests/test_viz/test_waterfall.py
@@ -179,3 +179,14 @@ def test_log(self, random_patch):
         assert (
             cb_label == expected_label
         ), f"Expected '{expected_label}', but got '{cb_label}'"
+
+    def test_incomplete_time_coord(self):
+        """Test waterfall plot with incomplete time coordinates (issue #534)."""
+        # Create a patch with aggregated time dimension (all NaN coordinates)
+        spool = dc.get_example_spool()
+        sub = spool.chunk(time=2, overlap=1)
+        aggs = dc.spool([x.max("time") for x in sub]).concatenate(time=None)[0]
+        # This should not raise an error
+        ax = aggs.viz.waterfall()
+        assert ax is not None
+        assert isinstance(ax, plt.Axes)
