Skip to content

Commit 6786829

Browse files
committed
review
1 parent 29239d4 commit 6786829

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

dascore/core/coordmanager.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ def _get_indexers_and_new_coords_dict(
132132
new_coords[coord_name] = (coord_dims, new_coord)
133133
continue
134134
# Handle dimensional coordinates (tied to exactly one dimension)
135-
_ensure_1d_coord(coord, coord_name)
136135
dim_name = coord_dims[0]
137136
# different logic if we are using indices or values
138137
method = getattr(coord, operation)

dascore/proc/hampel.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def hampel_filter(
9696
>>> data[10, 5] = 10 # Add a large spike
9797
>>> patch = patch.update(data=data)
9898
>>>
99-
>>> # Apply hampel filter along time dimension with 1.0 unit window
99+
>>> # Apply hampel filter along time dimension with 0.2 unit window
100100
>>> filtered = patch.hampel_filter(time=0.2, threshold=3.5)
101101
>>> assert filtered.data.shape == patch.data.shape
102102
>>> # The spike should be reduced

tests/test_proc/test_proc_coords.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ def test_select_multiple_nonexistent_coordinates_raises_error(self, random_patch
354354
PatchCoordinateError.
355355
"""
356356
# Try to select on multiple coordinates that don't exist
357-
with pytest.raises(PatchCoordinateError, match="coord1.*coord2"):
357+
with pytest.raises(PatchCoordinateError, match=r"coord1.*coord2"):
358358
random_patch.select(bad_coord1=(0, 10), bad_coord2=(5, 15))
359359

360360
def test_select_mix_valid_invalid_coordinates_raises_error(self, random_patch):

0 commit comments

Comments
 (0)