Skip to content

Add ZStringWriter#50

Merged
neuecc merged 1 commit intoCysharp:masterfrom
lahma:ZStringWriter
Apr 29, 2021
Merged

Add ZStringWriter#50
neuecc merged 1 commit intoCysharp:masterfrom
lahma:ZStringWriter

Conversation

@lahma
Copy link
Copy Markdown
Contributor

@lahma lahma commented Apr 23, 2021

fixes #49

@lahma lahma mentioned this pull request Apr 23, 2021
Closed
@lahma
Copy link
Copy Markdown
Contributor Author

lahma commented Apr 23, 2021 •
edited
Loading

If Utf8ValueStringBuilder and Utf16ValueStringBuilder would implement an interface writer could also have a generic parameter. I think CLR would be able to devirtualize it to direct struct usage without boxing.

@neuecc
Copy link
Copy Markdown
Member

neuecc commented Apr 29, 2021

Thank you!
I'll merge! (Any tweaks for Unity will be done by me after the merge and released soon after)

@neuecc neuecc merged commit 7bf1a46 into Cysharp:master Apr 29, 2021
@lahma lahma deleted the ZStringWriter branch April 29, 2021 08:54
@lahma lahma mentioned this pull request Sep 6, 2023
Merged
@lahma lahma mentioned this pull request Mar 28, 2024
Merged
@sebastienros
Copy link
Copy Markdown

sebastienros commented Mar 28, 2024

🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Built-in support for TextWriter implementations

3 participants

@lahma @neuecc @sebastienros