Merged
Conversation
Contributor
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Contributor
Author
|
Hi @neuecc, I hope you will review this PR. |
Member
|
sorry for delayed response. |
Member
|
good catch. |
ThangwLee
pushed a commit
to WolffunGame/ZString
that referenced
this pull request
May 26, 2023
Optimize for bool type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boolean.ToString()returns a constant so there is no allocation, but there is a cost to convert it to UTF8.That's why I used
Utf8Formatter.TryFormat.Other minor optimizations include.