Removes allocation when using IntPtr and Nullable<T>.#24
Merged
neuecc merged 4 commits intoCysharp:masterfrom Aug 3, 2020
Merged
Removes allocation when using IntPtr and Nullable<T>.#24neuecc merged 4 commits intoCysharp:masterfrom
neuecc merged 4 commits intoCysharp:masterfrom
Conversation
8f708a0 to
369667c
Compare
…pport-for-IntPtr-UIntPtr
Contributor
Author
|
@neuecc Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntPtrIntPtr does not support formatting, but it is the "basic" numeric type of the system.
However, when used with ZString, it causes a heap allocation.
I believe there needs to be built-in support for it.
The specification of IntPtr.ToString() is quoted below.
Before
After
The benchmark code is as below.
Details
Nullable<T>String.Format supports formatting for Nullable types.
In ZString Ver2.1.3, heap allocation occurs.
Before
After
The benchmark code is as below.
Details
IFormattableFor convenience, If you implement IFormattable, call
ToString(string format, IFormatProvider formatProvider).However, allocation will occur.