Merged
Conversation
udaken
force-pushed
the
add-StringBuilder-AppendJoin
branch
from
ccf417c to
6a301ba
Compare
Contributor
Author
|
The dependent PRs have been merged and the branch has been updated. |
Contributor
Author
|
For testing, I couldn't find a class that implements Therefore, I apologize for not testing well against the |
Member
…uilder-AppendJoin fixed the conflict with Cysharp#22.
Contributor
Author
ThangwLee
pushed a commit
to WolffunGame/ZString
that referenced
this pull request
May 26, 2023
Add StringBuilder.AppendJoin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no way to join the current ZString to avoid the allocation.
The BCL includes a StringBuilder.AppendJoin Method.
https://docs.microsoft.com/en-us/dotnet/api/system.text.stringbuilder.appendjoin?view=netcore-3.1
I have implemented AppendJoin to ZString.
NOTE: This PR is waiting for #19 and #20.