Implement ZString.Concat works as same as string.Concat on collection types#19
Merged
neuecc merged 3 commits intoCysharp:masterfrom Jul 30, 2020
Merged
Conversation
Contributor
|
Hi @piti6 . What about using public static string Concat<T>(params T[] values)
{
return JoinInternal<T>(default, values.AsSpan());
} |
Contributor
Author
|
@udaken I`m pretty sure they are almost same and as I used your code as reference, it would be good choice. I'll fix it. Thank you! |
Member
|
Sorry for the delayed response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using of ZString.Concat on collection types leads to the wrong result that users would expecting the result as same as string.Concat.
https://github.com/Cysharp/ZString/compare/master...piti6:implement-Concat-from-collections?expand=1#diff-eb70c70af0fdc6be03f85a109ae3909dR136-R145
Expected: Test succeeds without failure.
Result: