Skip to content

SPDX: revisit is_expression #781

Closed
Closed

Description

@jkowalleck

The 9.0.0-dev is_expression is not validating SPDX expressions in general, because verification is done against the scancode license DB that you refused to take as reference.

If you would extend the tests as I did you would see that it is not working as documented in the SPDX spec.
For example, custom LicenceRef-* license references are not considered as correct except those that are listed in Scancode's DB. License item validation happens only against the internal ScanCode DB.

Please look into the function description of Licensing.parse and the code of license-expression in general to see how it works.

Originally posted by @Joerki in #773 (comment)

Activity

  1. jkowalleck commented on Feb 12, 2025

    @jkowalleck
    MemberAuthor

    will add additional tests
    and see how the code may be fixed so tests are passing.


    see drafted tests from #77

  2. added this to the 9.0.0 milestone on Feb 12, 2025
  3. added a commit that references this issue on Feb 13, 2025
    e0da86d
  4. jkowalleck commented on Feb 13, 2025

    @jkowalleck
    MemberAuthor

    closed via #782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    QAQuality AssurancequestionFurther information is requested

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions