You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: no longer throw unexpected NoPropertiesProvidedException #776
some classes have only optional arguments/properties.
for some reason, they throw NoPropertiesProvidedException('At least one of ... must be provided for ...').
this is (at least with CDX 1.6) not true for most data models. Per spec, most models really dont require any properties.
This is especially annoying when you wanted to start with an empty object and add properties later. You simply cant, starting with an empty one will just throw an Error and that is it.
goal
allow creation of empty objects/model where the spec allows it.
implementation
make all these NoPropertiesProvidedException warnings.
or remove them entirely.
changed the title [-]donoever throw a `NoPropertiesProvidedException`[/-][+]feat: do longer throw unexpected `NoPropertiesProvidedException`[/+]on Feb 11, 2025
changed the title [-]feat: do longer throw unexpected `NoPropertiesProvidedException`[/-][+]feat: no longer throw unexpected `NoPropertiesProvidedException`[/+]on Feb 12, 2025
Activity
[-]donoever throw a `NoPropertiesProvidedException`[/-][+]feat: do longer throw unexpected `NoPropertiesProvidedException`[/+]NoPropertiesProvidedExceptionwhen deserializing emptyOrganizationalContact#771NoPropertiesProvidedExceptionwhen deserializing emptyOrganizationalEntity#764indiVar0508 commentedon Feb 11, 2025
Hi
I would like to volunteer for this issue!
jkowalleck commentedon Feb 12, 2025
sure. go ahead, @indiVar0508
please open a draft pullrequest early, and i will assign you this ticket then.
[-]feat: do longer throw unexpected `NoPropertiesProvidedException`[/-][+]feat: no longer throw unexpected `NoPropertiesProvidedException`[/+]indiVar0508 commentedon Feb 18, 2025
Hi @jkowalleck ,
raised a draft PR for in #786 , removed only for one place and documented in PR desc places where i found
steps followed
you can check once if you are ok with removal then will update PR removing all of them