Repository navigation
BUG: arbitrary dict comparison causes issues #598
Description
dict comparison causes issues.
this is new in v7.3.1, did not happen with v7.3.0
File "/.../.venv/lib/python3.11/site-packages/sortedcontainers/sortedset.py", line 359, in add
self._list.add(value)
File "/.../.venv/lib/python3.11/site-packages/sortedcontainers/sortedlist.py", line 279, in add
insort(_lists[pos], value)
File "/.../.venv/lib/python3.11/site-packages/cyclonedx/model/component.py", line 1701, in __lt__
return _ComparableTuple((
^^^^^^^^^^^^^^^^^^
File "/.../.venv/lib/python3.11/site-packages/cyclonedx/_internal/compare.py", line 41, in __lt__
return True if s < o else False
^^^^^
TypeError: '<' not supported between instances of 'dict' and 'dict'
CRITICAL | CDX > '<' not supported between instances of 'dict' and 'dict'
v7.3.1 introduced a feature, and hide it as a bug fix ...
anyway, the v7.3.1 SHOULD be yanked, and a fixed version must be released.
Activity
jkowalleck commentedon Apr 25, 2024
the qualifiers dict seams to be the issue ...
jkowalleck commentedon Apr 25, 2024
background: PackageURL shows itself as named tuple.
tupe comparrison is fine.
BUT one o the tuples values is a dict: qualifiers. and when the tuple comes to compare its elements, it will have issues comparing the qualifiers - and raise an error.
jkowalleck commentedon Apr 25, 2024
@madpah FYI.
I will fix this and yank the broken version afterwards
[-]BUG: arbitrary dict comparrsson causes issues[/-][+]BUG: arbitrary dict comparison causes issues[/+]fix: properly sort components based on all properties (#599)