Conversation
--- include/crow/http_response.h (before formatting)
+++ include/crow/http_response.h (after formatting)
@@ -246,6 +246,5 @@
std::function<void()> complete_request_handler_;
std::function<bool()> is_alive_helper_;
static_file_info file_info;
-
};
} // namespace crow |
luca-schlecker
approved these changes
Dec 3, 2021
Collaborator
luca-schlecker
left a comment
luca-schlecker
left a comment
There was a problem hiding this comment.
Looking good and functions as expected. 👍
Merged
Merged
|
Clang 13 with Libc++. at the end of functions do_write_static() and do_write_general() solves the problem. |
Member
Author
|
@alexeimenshikh Thanks for pointing this out, it's already been implemented in #332 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the file sending logic to the connection class and adds the necessary checks for errors or the need to close the connection and delete the object.
closes #291