Repository navigation
Commit 730681a
test(extensions): pin that every drifted extension stays covered by the delivery tests
Address Copilot review round 2 on github#4394.
The update-delivery tests draw their parametrized cases from the live
catalog, so an extension that lost its `bundled` flag, its catalog entry,
or its in-repo manifest silently dropped out of both tests, and the
DRIFTED_BEFORE_BUMP guard inside them never ran for it. The previous
presence test only asserted the case list was non-empty.
Replace it with test_drifted_extensions_are_covered, which asserts every
extension in DRIFTED_BEFORE_BUMP is still a bundled, in-repo catalog
entry. De-bundling one of them is a deliberate decision that should
update that set rather than silently shrink coverage. Verified: clearing
the bundled flag on `assess` drops its cases from the parametrized tests
and this test is the only one that fails.
Refs github#4345
Co-Authored-By: Claude Fable 5.1 <[email protected]>1 parent a21a34f commit 730681a
1 file changed
Lines changed: 14 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
95 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
96 | 108 | | |
97 | 109 | | |
98 | 110 | | |
| |||
0 commit comments