Use requests stream and shutil.copyfileobj to constrain memory usage during resource copy - #236
Merged
evamaxfield merged 5 commits intoMay 14, 2023
Conversation
- When copying resources from a remote origin over HTTP(S) prefer to stream the response body and copy chunks into the destination file insead of loading the entire file into memory first before writing.
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 71.67% 72.12% +0.45%
==========================================
Files 50 50
Lines 3329 3376 +47
==========================================
+ Hits 2386 2435 +49
+ Misses 943 941 -2
|
- Add requests_mock dependency so that we can mock an https origin with an mp4 file.
evamaxfield
approved these changes
May 14, 2023
evamaxfield
left a comment
evamaxfield
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Thanks! I am out right now so I will merge this now but can release later today in like 6 hours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #235
Description of Changes