Remove Unneccessary Re-Encode If Video Is Already H264 - #234
Merged
evamaxfield merged 6 commits intoMay 8, 2023
Merged
Conversation
- if video_filepath ext is mp4 and ffmpeg probe finds video stream with h264 codec add codec:copy to StreamCopy the video instead of re-encoding as h264.
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 71.67% 71.95% +0.27%
==========================================
Files 50 50
Lines 3329 3362 +33
==========================================
+ Hits 2386 2419 +33
Misses 943 943
|
Member
|
Seems good to me! Will merge and cut a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves #233
Description of Changes
Context: In clip_and_reformat_video if the video is already mp4/h264 encoded, the ffmpeg stream will re-encode the clipped portion (if clipping is present) or in the worst case re-encode the whole video again as h264.
This PR modifies the behavior of clip_and_reformat_video such that…
… then ffmpeg stream will use ffmpeg's StreamCopy codec to copy the video/audio streams to the output file instead of decoding and encoding the input and output streams respectively. According to ffmpeg: "it is very fast and there is no quality loss."
This change should result in a significant decrease in Event Gather pipeline runtime for data sources that already provide mp4/h264 encoded videos.