docs/improve-dev-infra-setup - #229
Merged
isaacna merged 4 commits intoMar 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
=======================================
Coverage 72.16% 72.16%
=======================================
Files 50 50
Lines 3316 3316
=======================================
Hits 2393 2393
Misses 923 923 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
evamaxfield
approved these changes
Mar 9, 2023
evamaxfield
left a comment
evamaxfield
left a comment
Member
There was a problem hiding this comment.
Minor comments / changes. Thanks!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Some of the steps in the dev-infrastructure README were out of order, so rearranging them based on my recent setup experience. Also added:
dev-cookiecutter-metadata.yamlwas not included as one of the copied files as part ofget_cdp_infrastructure_stack, which would cause the setup to fail if there was a directory chosen besides the defaultcdp-backend/dev-infrastructure.cookiecutter_yamlparam to thesetup-and-deployjust command in case it's desired