Skip to content

Add equals/hashCode implementations to the EntityGraph classes - #22

Merged
reda-alaoui merged 2 commits into
Cosium:masterfrom
thyming:equals-hashcode-implementations
Dec 13, 2018
Merged

Add equals/hashCode implementations to the EntityGraph classes#22
reda-alaoui merged 2 commits into
Cosium:masterfrom
thyming:equals-hashcode-implementations

Conversation

@thyming

@thyming thyming commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Closes #21.

@codecov-io

codecov-io commented Dec 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #22 into master will increase coverage by 1.05%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     77.83%   78.89%   +1.05%     
- Complexity      102      116      +14     
============================================
  Files            22       22              
  Lines           361      379      +18     
  Branches         44       52       +8     
============================================
+ Hits            281      299      +18     
+ Misses           66       62       -4     
- Partials         14       18       +4
Impacted Files Coverage Δ Complexity Δ
...ta/jpa/entity/graph/domain/DynamicEntityGraph.java 72.22% <55.55%> (+16.66%) 9 <5> (+6) ⬆️
...data/jpa/entity/graph/domain/NamedEntityGraph.java 95% <88.88%> (-5%) 13 <7> (+7)
...a/jpa/entity/graph/domain/AbstractEntityGraph.java 68.42% <0%> (+10.52%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f63315...233b32e. Read the comment docs.

@reda-alaoui

Copy link
Copy Markdown
Member

Thank you @thyming .
Could you add tests on the two classes?

@thyming

thyming commented Dec 13, 2018

Copy link
Copy Markdown
Contributor Author

Sure thing, done.

@reda-alaoui
reda-alaoui merged commit cc4f82a into Cosium:master Dec 13, 2018
@reda-alaoui

Copy link
Copy Markdown
Member

Thank you @thyming
I am releasing right now.

@thyming

thyming commented Dec 13, 2018 via email

Copy link
Copy Markdown
Contributor Author

@reda-alaoui

Copy link
Copy Markdown
Member

2.0.7 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants