Add a fixed frequency schedule #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When just adding the frequency to the current time, due to the system load the execution time will shift by a few milliseconds every run. This is now fixed
Member
|
Thank you for your contribution! When using a fixed delay schedule, the shifting of a few milliseconds after each run is expected: https://github.com/Coreoz/Wisp/tree/master?tab=readme-ov-file#basics-schedules To get around this, the existing solution to have a fixed frequency schedule is to use a cron expression: https://github.com/Coreoz/Wisp?tab=readme-ov-file#cron I am not against creating a fixed delay schedule implementation though. If you are interested, can you update your PR with:
|
amanteaux
changed the title
Contributor
Author
|
Done 👍🏼 |
Member
|
Thank you!! And sorry for the merge delay! |
Contributor
Author
|
No worries. I have to thank you for the merge 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When just adding the frequency to the current time, due to the system load the execution time will shift by a few milliseconds every run. So after a few hundred runs the delay will no longer be f.ex. 5 minutes but 5 minutes and 10 seconds. This is now fixed by always calculating the time remaining