Repository navigation
fix(local): wrapper固定worktree削除を防止 - #270
Merged
Merged
Conversation
ローカルentrypointはdeploy元worktree内のbinaryとguardrailsを固定参照するため、cleanupでそのworktreeを削除すると起動不能になる。 削除前に固定先を検出できるmanifestとassertコマンドを追加し、運用手順もAGENTSに残して再発を防ぐ。 Closes #269
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
|
The following comment was made by an LLM, it may be inaccurate: |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
① なぜ
~/.local/bin/opencode-live-guardrails-wrapperは local deploy 元 worktree 内の built binary と guardrails wrapper を固定参照します。その worktree を cleanup で削除すると、Git 上の cleanup は正しくても local
opencode起動が壊れます。これまでは削除前に wrapper を人間が読む運用に寄っており、再発防止として不十分でした。Closes #269
② どう実装したか
scripts/local-dev-deploy.shで wrapper 固定先 manifestopencode-live-guardrails-wrapper.jsonを生成bun run local:assert-not-pinned -- <worktree-path>を追加し、削除対象 worktree が wrapper の固定先なら失敗local:checkに manifest 照合を追加③ レビューしてほしい点
local:deploy/local:fix/local:checkの運用を壊していないか④ テスト・確認方法
bash -n scripts/local-dev-deploy.shgit diff --checkpackages/opencode:bun typecheckpackages/opencode:bun run test:httpapibun run local:deploybun run local:check~/.local/bin/opencode --version~/.local/bin/opencode debug infopackages/opencode:bun test --timeout 30000 test/cli/smokes/local-deploy.test.tsbun run local:assert-not-pinned -- <current-pinned-worktree>が block することbun run local:assert-not-pinned -- <tmpdir>が pass すること