Skip to content

bug: persistent e2e flaky tests in packages/app (workspace, settings, status-popover) #166

Closed

Description

@terisuke

Summary

Multiple e2e tests in packages/app are persistently flaky on the fork's CI runner (ubuntu-latest, 2vCPU). These failures appear across unrelated PRs (#164, #165) and on the dev branch itself, confirming they are NOT PR-caused.

Failing Tests

Hard fails (appear in multiple runs)

  • session-model-persistence.spec.ts:239 — "session model restore across workspaces"
  • settings-keybinds.spec.ts:279 — "terminal toggle keybind persists after reload"
  • workspace-new-session.spec.ts:46 — "new sessions from sidebar workspace actions stay in selected workspace"

Flaky (pass on retry sometimes)

  • workspaces.spec.ts:225 — "can reorder workspaces by drag and drop"
  • settings-models.spec.ts:53 — "showing a hidden model restores it to the model picker"
  • status-popover.spec.ts:3,26,41 — status popover open/tab switching
  • settings.spec.ts:432 — settings reload (color scheme, code font, UI font rehydrate)

Root Cause Candidates

  • openSettings() / waitSession() timeout in packages/app/e2e/actions.ts (lines 309, 414, 819)
  • page.reload() causing net::ERR_ABORTED
  • 2vCPU runner insufficient for Playwright + app startup timing

Evidence

Suggested Fix

  • Increase timeouts for openSettings() / waitSession() on CI
  • Add retry/wait logic for popover visibility checks
  • Consider quarantining known flaky tests with test.fixme() until fixed

Activity

  1. terisuke commented on Apr 11, 2026

    @terisuke
    Author

    Cross-reference

    Related to #129 (CI runner downgrade). Both issues share the same root cause: 2vCPU ubuntu-latest runner causing timing-dependent test failures.

    Proposed resolution: Fix both in a single Wave. Key files:

    • packages/app/e2e/actions.ts (L309, L414, L819) — increase timeouts
    • Session/workspace/settings spec files — add stable wait logic after reload

    Blocked: #149 depends on this being resolved first.

  2. added a commit that references this issue on Apr 11, 2026
    002b402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions