@@ -284,6 +284,34 @@ const seed = Effect.fn("test.seed")(function* (sessionID: SessionID, opts?: { fi
284284 return { user : msg , assistant }
285285} )
286286
287+ const broken = Effect . fn ( "test.broken" ) ( function * ( sessionID : SessionID , text : string , parentID ?: MessageID ) {
288+ const session = yield * Session . Service
289+ const id = parentID ?? ( yield * user ( sessionID , "hello" ) ) . id
290+ const msg : MessageV2 . Assistant = {
291+ id : MessageID . ascending ( ) ,
292+ role : "assistant" ,
293+ parentID : id ,
294+ sessionID,
295+ mode : "build" ,
296+ agent : "build" ,
297+ cost : 0 ,
298+ path : { cwd : "/tmp" , root : "/tmp" } ,
299+ tokens : { input : 0 , output : 0 , reasoning : 0 , cache : { read : 0 , write : 0 } } ,
300+ modelID : ref . modelID ,
301+ providerID : ref . providerID ,
302+ time : { created : Date . now ( ) , completed : Date . now ( ) } ,
303+ }
304+ yield * session . updateMessage ( msg )
305+ yield * session . updatePart ( {
306+ id : PartID . ascending ( ) ,
307+ messageID : msg . id ,
308+ sessionID,
309+ type : "text" ,
310+ text,
311+ } )
312+ return msg
313+ } )
314+
287315const addSubtask = ( sessionID : SessionID , messageID : MessageID , model = ref ) =>
288316 Effect . gen ( function * ( ) {
289317 const session = yield * Session . Service
@@ -325,6 +353,54 @@ it.live("loop exits immediately when last assistant has stop finish", () =>
325353 ) ,
326354)
327355
356+ it . live ( "loop ignores unfinished assistant pollution when building the next turn" , ( ) =>
357+ provideTmpdirServer (
358+ Effect . fnUntraced ( function * ( { llm } ) {
359+ const prompt = yield * SessionPrompt . Service
360+ const sessions = yield * Session . Service
361+ const chat = yield * sessions . create ( {
362+ title : "Pinned" ,
363+ permission : [ { permission : "*" , pattern : "*" , action : "allow" } ] ,
364+ } )
365+ const msg = yield * user ( chat . id , "check PR #412" )
366+ yield * broken (
367+ chat . id ,
368+ "`apps/liff` `StatusPage` `LiffProvider` `Wave 1B` `apps/liff` `StatusPage` `LiffProvider`" ,
369+ msg . id ,
370+ )
371+ yield * llm . text ( "PR #412 is still open." )
372+
373+ const result = yield * prompt . loop ( { sessionID : chat . id } )
374+ expect ( result . info . role ) . toBe ( "assistant" )
375+ expect ( result . parts . some ( ( part ) => part . type === "text" && part . text === "PR #412 is still open." ) ) . toBe ( true )
376+
377+ const [ hit ] = yield * llm . inputs
378+ expect ( JSON . stringify ( hit ) ) . not . toContain ( "apps/liff" )
379+ expect ( JSON . stringify ( hit ) ) . not . toContain ( "LiffProvider" )
380+ } ) ,
381+ { git : true , config : providerCfg } ,
382+ ) ,
383+ )
384+
385+ it . live ( "loop returns the last finished assistant when a stale unfinished assistant trails it" , ( ) =>
386+ provideTmpdirServer (
387+ Effect . fnUntraced ( function * ( { llm } ) {
388+ const prompt = yield * SessionPrompt . Service
389+ const sessions = yield * Session . Service
390+ const chat = yield * sessions . create ( { title : "Pinned" } )
391+ const seeded = yield * seed ( chat . id , { finish : "stop" } )
392+ yield * broken ( chat . id , "stale broken thinking output" , seeded . user . id )
393+
394+ const result = yield * prompt . loop ( { sessionID : chat . id } )
395+ expect ( result . info . role ) . toBe ( "assistant" )
396+ expect ( result . info . id ) . toBe ( seeded . assistant . id )
397+ expect ( result . parts . some ( ( part ) => part . type === "text" && part . text === "hi there" ) ) . toBe ( true )
398+ expect ( yield * llm . calls ) . toBe ( 0 )
399+ } ) ,
400+ { git : true , config : providerCfg } ,
401+ ) ,
402+ )
403+
328404it . live ( "loop calls LLM and returns assistant message" , ( ) =>
329405 provideTmpdirServer (
330406 Effect . fnUntraced ( function * ( { llm } ) {
0 commit comments