Repository navigation
fix: submit the home composer on Enter - #95
Merged
jerelvelarde merged 1 commit intoOct 6, 2026
Merged
Conversation
Signed-off-by: Charan Rathore <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
jerelvelarde
approved these changes
Oct 6, 2026
jerelvelarde
left a comment
jerelvelarde
left a comment
Collaborator
There was a problem hiding this comment.
Useful template interaction fix: Enter submits the home composer through the existing form, while Shift+Enter, both IME guards, empty/unconfigured states and held creation remain safe. Seven unit tests and Chromium checks on the actual App with intercepted API calls pass, including repeated Enter producing one POST. Full branch checks pass. No correctness or security blocker. Combined integration with current main passes 265 tests, type checking, lint, formatting and the production build; this exact PR head has successful CI.
jerelvelarde
added a commit
that referenced
this pull request
Oct 6, 2026
* feat(pages): add page deletion with safe subpage reparenting * fix(pages): keep review receipts on delete, drop unused delete tool, cover cleanup in tests * fix(pages): handle deleted reviewed pages, avoid stale draft prompt, document deletion * fix(pages): drop deleted pages from the library and resync reparented children * fix(pages): ignore stale deletion after leaving the page and clear saved receipt on deletion * Track OpenDots browser setup and Intelligence signup usage (#97) * Track OpenDots runtime usage for Intelligence signup reporting * Track browser setup and verify OpenDots reporting in PostHog * fix: distinguish scheduled turns and neutralize task activity logs (#105) * fix: distinguish scheduled turns and neutralize task activity logs * fix: keep scheduled prompt label readable --------- Co-authored-by: Jerel John Velarde <[email protected]> * fix(research): keep balanced brackets in URLs from the research prompt (#99) * fix(research): keep balanced brackets in URLs from the research prompt Signed-off-by: Charan Rathore <[email protected]> * fix(research): parse Markdown link boundaries when the label is a URL A link like [https://example.com](https://example.com) let the label swallow the destination, so both research adapters received a malformed URL. Split the ]( boundary before matching so the two occurrences are read separately, keeping the balanced-delimiter trimming. Adds the regression test from review. Signed-off-by: Charan Rathore <[email protected]> --------- Signed-off-by: Charan Rathore <[email protected]> * fix: answer 404 for a conversation, call or Dot that does not exist (#98) Signed-off-by: Charan Rathore <[email protected]> * fix: submit the home composer on Enter (#95) Signed-off-by: Charan Rathore <[email protected]> * fix: return 400 instead of 503 for malformed JSON and invalid Space access (#11) * fix: return 400 for malformed JSON and invalid Space access on workspace routes Malformed request bodies on /api/spaces, /api/dots, /api/conversations and /api/voice/calls, and Dot create/update with an unknown Space, fell through to the generic 503 handler, which tells the caller to check server configuration. Return 400 with a specific message instead, matching the page routes. Signed-off-by: asemabdallah <[email protected]> * fix: handle malformed request JSON at the body-parsing boundary Catch JSON parse failures where each workspace route reads its request body instead of mapping every SyntaxError to 400 in the global handler. Malformed caller JSON still gets a 400 from the route's schema check, while a SyntaxError raised by an upstream service call stays a 503. Add a regression test for the upstream case. Signed-off-by: asemabdallah <[email protected]> --------- Signed-off-by: asemabdallah <[email protected]> * style: unify the ink accent, fix text contrast, and clarify disabled states (#82) * style: unify the ink accent, fix contrast, and clarify disabled states The compact-chrome layer moved the app to an ink palette, but primary buttons, focus rings, checkboxes, and setup notes kept the original lavender, so Settings and Contacts looked like a different app. - Primary buttons, focus rings, and checkboxes use one ink accent. - Disabled primary/send/connect buttons look disabled (the send button was near-black at 90% opacity before setup). - Secondary text in setup cards, config notes, and permission rows meets WCAG AA (was ~2.4-2.7:1, now 5.3:1). - Settings shows missing environment variables as code. - Sidebar: Spaces gets the same spacing as Dots, labels stay on one line, and zero-count badges are hidden. Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix: keep the call view's pale focus ring on its dark surface Review fix: the ink focus outline now excludes controls inside .call-view, so they keep the base #b8c4fa 3px ring instead of a #242424 ring with ~1.3-1.8:1 contrast on the dark call background. Verified in Chromium with keyboard focus: call control #b8c4fa 3px; other controls #242424 2px. Co-Authored-By: Claude Opus 5.5 <[email protected]> --------- Co-authored-by: Claude Opus 5.5 <[email protected]> --------- Signed-off-by: Charan Rathore <[email protected]> Signed-off-by: asemabdallah <[email protected]> Co-authored-by: Jerel Velarde <[email protected]> Co-authored-by: Twil3akine <[email protected]> Co-authored-by: Jerel John Velarde <[email protected]> Co-authored-by: Charan Rathore <[email protected]> Co-authored-by: Asem ahmed <[email protected]> Co-authored-by: Jibran Tahir <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
asasemahmed
added a commit
to asasemahmed/FullDots
that referenced
this pull request
Oct 11, 2026
Enter sends the first message from the home screen like it does in a conversation; Shift+Enter adds a line, and IME composition is ignored. Ported from CopilotKit/OpenDots#95 (upstream commit 9e9f22c).
superops-team
pushed a commit
to superops-team/OpenMPA
that referenced
this pull request
Oct 29, 2026
Signed-off-by: Charan Rathore <[email protected]>
superops-team
pushed a commit
to superops-team/OpenMPA
that referenced
this pull request
Oct 29, 2026
…Kit#49) * feat(pages): add page deletion with safe subpage reparenting * fix(pages): keep review receipts on delete, drop unused delete tool, cover cleanup in tests * fix(pages): handle deleted reviewed pages, avoid stale draft prompt, document deletion * fix(pages): drop deleted pages from the library and resync reparented children * fix(pages): ignore stale deletion after leaving the page and clear saved receipt on deletion * Track OpenDots browser setup and Intelligence signup usage (CopilotKit#97) * Track OpenDots runtime usage for Intelligence signup reporting * Track browser setup and verify OpenDots reporting in PostHog * fix: distinguish scheduled turns and neutralize task activity logs (CopilotKit#105) * fix: distinguish scheduled turns and neutralize task activity logs * fix: keep scheduled prompt label readable --------- Co-authored-by: Jerel John Velarde <[email protected]> * fix(research): keep balanced brackets in URLs from the research prompt (CopilotKit#99) * fix(research): keep balanced brackets in URLs from the research prompt Signed-off-by: Charan Rathore <[email protected]> * fix(research): parse Markdown link boundaries when the label is a URL A link like [https://example.com](https://example.com) let the label swallow the destination, so both research adapters received a malformed URL. Split the ]( boundary before matching so the two occurrences are read separately, keeping the balanced-delimiter trimming. Adds the regression test from review. Signed-off-by: Charan Rathore <[email protected]> --------- Signed-off-by: Charan Rathore <[email protected]> * fix: answer 404 for a conversation, call or Dot that does not exist (CopilotKit#98) Signed-off-by: Charan Rathore <[email protected]> * fix: submit the home composer on Enter (CopilotKit#95) Signed-off-by: Charan Rathore <[email protected]> * fix: return 400 instead of 503 for malformed JSON and invalid Space access (CopilotKit#11) * fix: return 400 for malformed JSON and invalid Space access on workspace routes Malformed request bodies on /api/spaces, /api/dots, /api/conversations and /api/voice/calls, and Dot create/update with an unknown Space, fell through to the generic 503 handler, which tells the caller to check server configuration. Return 400 with a specific message instead, matching the page routes. Signed-off-by: asemabdallah <[email protected]> * fix: handle malformed request JSON at the body-parsing boundary Catch JSON parse failures where each workspace route reads its request body instead of mapping every SyntaxError to 400 in the global handler. Malformed caller JSON still gets a 400 from the route's schema check, while a SyntaxError raised by an upstream service call stays a 503. Add a regression test for the upstream case. Signed-off-by: asemabdallah <[email protected]> --------- Signed-off-by: asemabdallah <[email protected]> * style: unify the ink accent, fix text contrast, and clarify disabled states (CopilotKit#82) * style: unify the ink accent, fix contrast, and clarify disabled states The compact-chrome layer moved the app to an ink palette, but primary buttons, focus rings, checkboxes, and setup notes kept the original lavender, so Settings and Contacts looked like a different app. - Primary buttons, focus rings, and checkboxes use one ink accent. - Disabled primary/send/connect buttons look disabled (the send button was near-black at 90% opacity before setup). - Secondary text in setup cards, config notes, and permission rows meets WCAG AA (was ~2.4-2.7:1, now 5.3:1). - Settings shows missing environment variables as code. - Sidebar: Spaces gets the same spacing as Dots, labels stay on one line, and zero-count badges are hidden. Co-Authored-By: Claude Opus 5.5 <[email protected]> * fix: keep the call view's pale focus ring on its dark surface Review fix: the ink focus outline now excludes controls inside .call-view, so they keep the base #b8c4fa 3px ring instead of a #242424 ring with ~1.3-1.8:1 contrast on the dark call background. Verified in Chromium with keyboard focus: call control #b8c4fa 3px; other controls #242424 2px. Co-Authored-By: Claude Opus 5.5 <[email protected]> --------- Co-authored-by: Claude Opus 5.5 <[email protected]> --------- Signed-off-by: Charan Rathore <[email protected]> Signed-off-by: asemabdallah <[email protected]> Co-authored-by: Jerel Velarde <[email protected]> Co-authored-by: Twil3akine <[email protected]> Co-authored-by: Jerel John Velarde <[email protected]> Co-authored-by: Charan Rathore <[email protected]> Co-authored-by: Asem ahmed <[email protected]> Co-authored-by: Jibran Tahir <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #70 (first point only).
On a Dot's home screen, pressing Enter in the "Start a conversation" box added a new line; only the send button started the conversation. The in-thread composer already submits on Enter (and keeps Shift+Enter for a new line).
The home composer now uses the same key check as the in-thread one. Enter starts the conversation only when the box has text, the Dot is set up and nothing is already being created; otherwise it does nothing instead of adding a line. Shift+Enter and IME composition behave as before.
I did not change the other two points in #70 (the page chat input label is already there on main; the inspector-metadata 403 polling is separate).
Checked locally:
npx vitest run(39 files, 200 tests; three new tests cover Enter submit, the not-ready case and Shift+Enter),tsc --noEmit, eslint, prettier andnpm run buildpass. I did not open the home screen in a browser, so the textarea wiring itself is covered by typecheck and the key-handler tests, not by a rendered test.Prepared with AI assistance (Claude Code).