Skip to content

Conversation

@yelhousni
Copy link
Contributor

Description

  • refactor: remove dead code (addStep and FrobeniusCube)
  • refactor: use Mul which is now already a MulMod
  • perf: remove a redundant neg in bw6 pairing
  • perf: implement addchain for scalarMulBySeedSquare in bls12-381 AssertOnG1
  • refactor: clean some unused tests in fields

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

All tests pass.

How has this been benchmarked?

  • redundant neg saves 12 SCS
  • addchain in AssertIsOnG2 saves 379,942 SCS

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ivokub ivokub merged commit 5f1643d into master Jan 10, 2024
@ivokub ivokub deleted the clean/sw-and-fields branch January 10, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants