Skip to content

Conversation

@ThomasPiellard
Copy link
Collaborator

@ThomasPiellard ThomasPiellard commented Dec 12, 2023

Description

Adds a base circuit for batching plonk verifier circuits in a 2 chain.

Might conflict with #949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

  • TestBatchVerify

How has this been benchmarked?

~295k constraints per verifier

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub marked this pull request as ready for review December 14, 2023 23:54
@ivokub
Copy link
Collaborator

ivokub commented Dec 14, 2023

Done, see the tests TestBLS12InBW6Multi and TestBLS12InBW6MultiHashed for the usage.

Approx 287k constraints per circuit on average (over 20 circuits). If using hashing to save number of public inputs, then approx 288k constraints per circuit.

Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. But I guess I have made significant changes so would be good for @ThomasPiellard to also look before merging.

@ivokub ivokub merged commit a1bb3ee into master Dec 15, 2023
@ivokub ivokub deleted the feat/plonk-verifier-batching branch December 15, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants