Skip to content

Conversation

@Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Dec 1, 2023

Description

Minor improvements to compression:

  • Compressor can decide to bypass compression when appropriate
  • One byte at the beginning of the compressed file is dedicated to the compression algorithm version

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

All previous tests pass. No new tests were added.

How has this been benchmarked?

No benchmarks were run as the change is minimal.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabaie Tabaie requested a review from gbotrel December 1, 2023 18:23
@Tabaie Tabaie requested a review from gbotrel December 1, 2023 20:04
@gbotrel gbotrel merged commit 98a1c52 into master Dec 1, 2023
@gbotrel gbotrel deleted the chore/compression-v1 branch December 1, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants