Refactor, perf: 2-chains pairing + groth16 API #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yelhousni
commented
Apr 26, 2023
yelhousni
commented
- fixes Refactor 2-Chain std API #607 (for both bls12 and bls24 2-chains)
- consolidate pairing code with emulated package
- perf: saves 15 constraints for bls12/bw6 Groth16 and 63 for bls24/bw6
gbotrel
approved these changes
May 11, 2023
Collaborator
gbotrel
left a comment
gbotrel
left a comment
There was a problem hiding this comment.
lgtm 👍 modulo, probably changing FillG1K method name with something clearer and documented (like Allocate() maybe?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.