refactor: based on #515 generify groth16 MPC setup for all curves, flatten packages+ refactor #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivokub
requested changes
Mar 14, 2023
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
I think it looks good. Didn't go through the math exactly, hoping that @ThomasPiellard had a look.
Considering that the usage is more complex, I would recommend adding documentation example and a bit of package documentation. If sounds good, then can also do it myself.
Maybe would be good to add type-switched methods into backend/groth16?
internal/generator/backend/template/zkpschemes/groth16/mpcsetup/lagrange.go.tmpl
Outdated
Show resolved
Hide resolved
internal/generator/backend/template/zkpschemes/groth16/mpcsetup/lagrange.go.tmpl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #515 (cherry picked the commits from @HSG88 );
Did mostly stylistic edits; flattened the package structure, avoided couple of allocs, and generify for all curves.
To be merged after #561 ; MPC setup is now
gnark/backend/groth16/bn254/mpcsetup.A future PR (cc @HSG88 ) would probably be nice to ensure APIs don't panic but return errors + struct and public methods are documented (you can test output with
godoc) .On the perf note, the individual scalar mul on affine coordinates are a clear bottleneck, maybe we should use jacobian? (+ optimize the memory usage of the
mulGLVpath cc @yelhousni ingnark-crypto) .