Feat/iop refactor #451
Merged
Feat/iop refactor #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of plonk backend using the iop package provided by gnark-crypto.
The various vectors used in the plonk backend are now of type iop.WrappedPolynomial from gnark-crypto. Technical issues such as monitoring the layout of the vectors (bit reversed vs regular), or encoding shifted polynomial (e.g. from Z(X) get Z(g X) ) are automatically managed in the most cost effective way.
The multivariate polynomial capturing the full constraint system (that is the individual constraints + the ordering) is now encoded as an iop.Expression which is just a function ...fr.Element -> fr.Element, making the code way easier to debug and cleaner.