feat: adds api.MAC(..)
#427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency of debug info
ivokub
requested changes
Dec 22, 2022
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
Looks good. I think it is a clean and required change.
| func (builder *scs) MAC(a, b, c frontend.Variable) frontend.Variable { | ||
| // TODO can we do better here to limit allocations? | ||
| // technically we could do that in one PlonK constraint (against 2 for separate Add & Mul) | ||
| return builder.Add(a, builder.Mul(b, c)) |
Collaborator
There was a problem hiding this comment.
I think it can be done. And this is also helpful for the case if we want to have a transpiler from some other circuit description to gnark.
Collaborator
Author
There was a problem hiding this comment.
Am going to wait on @ThomasPiellard new backend on that one; plonk frontend is in a need of a refactor to convert input to term, and add custom constraints etc... keeping the TODO around for now.
Collaborator
|
Suggested edit: diff --git a/std/math/emulated/wrapped_api.go b/std/math/emulated/wrapped_api.go
index aa433d24..6d40f4ee 100644
--- a/std/math/emulated/wrapped_api.go
+++ b/std/math/emulated/wrapped_api.go
@@ -77,8 +77,10 @@ func (w *FieldAPI[T]) Add(i1 frontend.Variable, i2 frontend.Variable, in ...fron
}
func (w *FieldAPI[T]) MulAcc(a, b, c frontend.Variable) frontend.Variable {
- // TODO can we do better here to limit allocations?
- return w.Add(a, w.Mul(b, c))
+ els := w.varsToElements(a, b, c)
+ mul := w.f.Mul(els[1], els[2])
+ res := w.f.Add(els[0], mul)
+ return res
}
func (w *FieldAPI[T]) Neg(i1 frontend.Variable) frontend.Variable {
|
Collaborator
Tried to see if could reduce allocating new |
ivokub
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416 . Impact in
std/math/emulatedforrshis significant (~40% less memallocs).Also, this new api would result in less constraint in a PlonKish arithmetization, since it will create one constraint instead of 2.