feat: added serialization header to CS and debug info to all constraints with -tags=debug #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gbotrel
commented
Jul 21, 2022
gbotrel
commented
- feat: added GnarkVersion semver tag in cs serialized objects
- feat: store debug info stack for all constraints if debug tag is set
- doc: added TODO
- fix: round trip serialization test of cs
- fix: stack parsing
ivokub
reviewed
Jul 22, 2022
Collaborator
ivokub
left a comment
ivokub
left a comment
There was a problem hiding this comment.
I think the PR makes sense.
ivokub
approved these changes
Jul 22, 2022
gbotrel
added a commit
that referenced
this pull request
Aug 2, 2022
gbotrel
added a commit
that referenced
this pull request
Aug 3, 2022
* feat: added profile/ to output pprof style constraint profiler * feat: gnark/profile allows multiple overlapping profiling sessions * feat: added profile.Top() * feat: added profile.NbConstraints() * docs: added package level profile example * style: code cleaning * fix: fix CI trim path for test purposes * fix: fix previous commit * clean: revert part of #347 with redundant debug info * clean: remove deadcode and kill api.Tag and api.Counter * fix: saving files helps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.